kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ewen Cheslack-Postava (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-3055) JsonConverter mangles schema during serialization (fromConnectData)
Date Mon, 04 Jan 2016 16:48:39 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ewen Cheslack-Postava resolved KAFKA-3055.
------------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.9.1.0
                   0.9.0.1

Issue resolved by pull request 722
[https://github.com/apache/kafka/pull/722]

> JsonConverter mangles schema during serialization (fromConnectData)
> -------------------------------------------------------------------
>
>                 Key: KAFKA-3055
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3055
>             Project: Kafka
>          Issue Type: Bug
>          Components: copycat
>    Affects Versions: 0.9.0.0
>            Reporter: Kishore Senji
>            Assignee: Ewen Cheslack-Postava
>             Fix For: 0.9.0.1, 0.9.1.0
>
>
> Test case is here: https://github.com/ksenji/kafka-connect-test/tree/master/src/test/java/org/apache/kafka/connect/json
> If Caching is disabled, it behaves correctly and JsonConverterWithNoCacheTest runs successfully.
Otherwise the test JsonConverterTest fails.
> The reason is that the JsonConverter has a bug where it mangles the schema as it assigns
all String fields with the same name (and similar for all Int32 fields)
> This is how the schema & payload gets serialized for the Person Struct (with caching
disabled):
> {code}
> {"schema":{"type":"struct","fields":[{"type":"string","optional":false,"field":"firstName"},{"type":"string","optional":false,"field":"lastName"},{"type":"string","optional":false,"field":"email"},{"type":"int32","optional":false,"field":"age"},{"type":"int32","optional":false,"field":"weightInKgs"}],"optional":false,"name":"Person"},"payload":{"firstName":"Eric","lastName":"Cartman","email":"eric.cartman@southpark.com","age":10,"weightInKgs":40}}
> {code}
> where as when caching is enabled the same Struct gets serialized as (with caching enabled)
:
> {code}
> {"schema":{"type":"struct","fields":[{"type":"string","optional":false,"field":"email"},{"type":"string","optional":false,"field":"email"},{"type":"string","optional":false,"field":"email"},{"type":"int32","optional":false,"field":"weightInKgs"},{"type":"int32","optional":false,"field":"weightInKgs"}],"optional":false,"name":"Person"},"payload":{"firstName":"Eric","lastName":"Cartman","email":"eric.cartman@southpark.com","age":10,"weightInKgs":40}}
> {code}
> As we can see all String fields became "email" and all int32 fields became "weightInKgs".




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message