kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pierre-Yves Ritschard (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API
Date Thu, 21 Jan 2016 13:44:40 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110597#comment-15110597

Pierre-Yves Ritschard commented on KAFKA-3006:

[~granthenke] It's ready to be committed, but I do think there needs to be a final resolution
from project members to move forwards.

> Make collection default container type for sequences in the consumer API
> ------------------------------------------------------------------------
>                 Key: KAFKA-3006
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3006
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions:
>            Reporter: Pierre-Yves Ritschard
>              Labels: patch
> The KafkaConsumer API has some annoying inconsistencies in the usage of collection types.
For example, subscribe() takes a list, but subscription() returns a set. Similarly for assign()
and assignment(). We also have pause() , seekToBeginning(), seekToEnd(), and resume() which
annoyingly use a variable argument array, which means you have to copy the result of assignment()
to an array if you want to pause all assigned partitions. We can solve these issues by adding
the following variants:
> {code}
> void subscribe(Collection<String> topics);
> void subscribe(Collection<String> topics, ConsumerRebalanceListener);
> void assign(Collection<TopicPartition> partitions);
> void pause(Collection<TopicPartition> partitions);
> void resume(Collection<TopicPartition> partitions);
> void seekToBeginning(Collection<TopicPartition>);
> void seekToEnd(Collection<TopicPartition>);
> {code}
> This issues supersedes KAFKA-2991

This message was sent by Atlassian JIRA

View raw message