kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ismael Juma <ism...@juma.me.uk>
Subject Code Contribution wiki tweaks
Date Fri, 29 Jan 2016 08:41:48 GMT
Hi all,

I did a couple of tweaks to the "Contributing Code Changes"[1] wiki page:

1. I noted that PR submitters should add a comment to the PR after they've
addressed comments from reviewers (no notification is sent otherwise). I
added this because I noticed that some people weren't doing that and it
tends to cause the review process to take longer.

2. I changed the paragraph about dealing with conflicts to use merge
instead of rebase. Given that reviewers use the "Files changed" tab to
comment on the PR and that the merge script squashes commits before
merging, merging is better than rebasing because (1) it's easier for the
submitter and (2) it's easier for the reviewer to see what has changed
since the last review.

I think these changes are non-controversial (most people already do it this
way), but please do let me know if you disagree.

Ismael

[1]
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message