kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From crhyne <...@git.apache.org>
Subject [GitHub] kafka pull request: KAFKA-3161: Fixed ProducerConfig/ConsumerConfi...
Date Fri, 29 Jan 2016 16:58:10 GMT
GitHub user crhyne reopened a pull request:

    https://github.com/apache/kafka/pull/824

    KAFKA-3161: Fixed ProducerConfig/ConsumerConfig so that defaults are used in java.util.Properties

    This impacts the ProducerConfig and ConsumerConfig.  I added a unit test to reflect the
new case.  While running unit tests I found that the order for assertEquals(<expected>,
<actual>) were backwards - I fixed this.
    
    This is my original work to be licensed to the kafka product (Instructions 5d).


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/crhyne/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #824
    
----
commit 5c46a2711b5927b91d3076cd35675c1dd5eb6ca3
Author: Cliff Rhyne <crhyne@signal.co>
Date:   2016-01-28T16:02:08Z

    cleaned up use of java.util.Properties so that defaults are used https://issues.apache.org/jira/browse/KAFKA-3161

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message