Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Tue, 23 Dec 2014 00:24:13 +0000 (UTC)
From: "Gwen Shapira (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12762628.1418923145000.87735.1419294253772@Atlassian.JIRA>
In-Reply-To: <JIRA.12762628.1418923145000@Atlassian.JIRA>
References: <JIRA.12762628.1418923145000@Atlassian.JIRA>
 <JIRA.12762628.1418923145914@arcas>
Subject: [jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties
 key.separator and parse.key no longer work
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256363#comment-14256363 ] 

Gwen Shapira commented on KAFKA-1824:
-------------------------------------

I added tests, I also did some refactoring to ConsoleProducer to allow testing (i.e. pulled some portions off main() to separate functions where we can test them). 

One caveat - This patch removes an undocumented feature: 
Before the patch, properties specified in --property were passed to the producer (even though it is documented as properties for the MessageReader), so users could configure producer properties not supported by the console producer directly to the underlying producer.
Now the properties specified in --property are only sent to the reader, as documented.

If we think that allowing users to send custom properties to producer is useful, I can add an additional option (--producer-property).

> in ConsoleProducer - properties key.separator and parse.key no longer work
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-1824
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1824
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>            Assignee: Gwen Shapira
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1824.patch, KAFKA-1824.patch, KAFKA-1824_2014-12-22_16:17:42.patch
>
>
> Looks like the change in kafka-1711 breaks them accidentally.
> reader.init is called with readerProps which is initialized with commandline properties as defaults.
> the problem is that reader.init checks:
>     if(props.containsKey("parse.key"))
> and defaults don't return true in this case.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)