Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A86E5CEA0 for ; Tue, 23 Dec 2014 18:30:14 +0000 (UTC) Received: (qmail 8121 invoked by uid 500); 23 Dec 2014 18:30:14 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 8066 invoked by uid 500); 23 Dec 2014 18:30:14 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 8052 invoked by uid 99); 23 Dec 2014 18:30:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Dec 2014 18:30:14 +0000 Date: Tue, 23 Dec 2014 18:30:14 +0000 (UTC) From: "Gwen Shapira (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-1822) Add "echo" request MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257309#comment-14257309 ] Gwen Shapira commented on KAFKA-1822: ------------------------------------- Thanks! I think ClusterMetadataRequest can work here. I'll close this JIRA and re-use ClusterMetadataRequest. > Add "echo" request > ------------------ > > Key: KAFKA-1822 > URL: https://issues.apache.org/jira/browse/KAFKA-1822 > Project: Kafka > Issue Type: Improvement > Components: core > Reporter: Gwen Shapira > Assignee: Gwen Shapira > Fix For: 0.8.3 > > > Currently there is no simple way to generate a request and validate we receive a response without adding a lot of dependencies for the test. > Kafka request classes have quite a few dependencies, so they are not really usable when testing infrastructure components or clients. > Generating a byte-array with meaningless request key id as it is done in SocketServerTest results in unknown request exception that must be handled. > I suggest adding an EchoRequest, EchoResponse and EchoHandler. The Request will be the usual header and a bytearray. The Response will be a response header and the same bytearray echoed back. > Should be useful for client developers and when testing infrastructure changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)