Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C8EDAF4B9 for ; Fri, 12 Dec 2014 14:56:13 +0000 (UTC) Received: (qmail 71767 invoked by uid 500); 12 Dec 2014 14:56:13 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 71711 invoked by uid 500); 12 Dec 2014 14:56:13 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 71699 invoked by uid 99); 12 Dec 2014 14:56:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2014 14:56:13 +0000 Date: Fri, 12 Dec 2014 14:56:13 +0000 (UTC) From: "Gwen Shapira (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-1811) ensuring registered broker host:port is unique MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244220#comment-14244220 ] Gwen Shapira commented on KAFKA-1811: ------------------------------------- #3 - I think the main issue here is with the ZK registration. If the SocketServer fails to start, there will be no registration and therefore no uniqueness issue. Perhaps [~junrao] can confirm. #4 - Perhaps check how we maintain broker ID uniqueness? I think that just creating a znode in ZK with the id as the name will force ZK to guarantee uniqueness for us (by failing to write if the znode exists), but perhaps there is more involved. Anyway, may be a good place to start. [~nehanarkhede] may have better suggestions here. > ensuring registered broker host:port is unique > ---------------------------------------------- > > Key: KAFKA-1811 > URL: https://issues.apache.org/jira/browse/KAFKA-1811 > Project: Kafka > Issue Type: Improvement > Reporter: Jun Rao > Labels: newbie > Attachments: KAFKA_1811.patch > > > Currently, we expect each of the registered broker to have a unique host:port pair. However, we don't enforce that, which causes various weird problems. It would be useful to ensure this during broker registration. -- This message was sent by Atlassian JIRA (v6.3.4#6332)