Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AE628105B1 for ; Wed, 3 Dec 2014 20:03:13 +0000 (UTC) Received: (qmail 33832 invoked by uid 500); 3 Dec 2014 20:03:13 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 33771 invoked by uid 500); 3 Dec 2014 20:03:13 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 33759 invoked by uid 99); 3 Dec 2014 20:03:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2014 20:03:13 +0000 Date: Wed, 3 Dec 2014 20:03:13 +0000 (UTC) From: "Guozhang Wang (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233450#comment-14233450 ] Guozhang Wang commented on KAFKA-1805: -------------------------------------- Thanks Thomas for pointing this out, looking forward for your patch. > Kafka ProducerRecord should implement equals > -------------------------------------------- > > Key: KAFKA-1805 > URL: https://issues.apache.org/jira/browse/KAFKA-1805 > Project: Kafka > Issue Type: Improvement > Components: producer > Affects Versions: 0.8.2 > Reporter: Thomas Omans > Assignee: Jun Rao > Priority: Minor > > I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. > This makes tests integrating kafka particularly awkward. > https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java > I can whip up a patch since this is essentially just a value object. > Thanks, > Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)