Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0301C1041C for ; Wed, 31 Dec 2014 00:01:25 +0000 (UTC) Received: (qmail 80158 invoked by uid 500); 31 Dec 2014 00:01:25 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 80106 invoked by uid 500); 31 Dec 2014 00:01:25 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 80092 invoked by uid 99); 31 Dec 2014 00:01:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 31 Dec 2014 00:01:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DDFB81C8EF6; Wed, 31 Dec 2014 00:01:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7665594598673626190==" MIME-Version: 1.0 Subject: Re: Review Request 29210: Patch for KAFKA-1819 From: "Gwen Shapira" To: "kafka" , "Neha Narkhede" , "Joel Koshy" , "Gwen Shapira" Date: Wed, 31 Dec 2014 00:01:21 -0000 Message-ID: <20141231000121.31225.92011@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gwen Shapira" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/29210/ X-Sender: "Gwen Shapira" References: <20141226215850.10621.99531@reviews.apache.org> In-Reply-To: <20141226215850.10621.99531@reviews.apache.org> Reply-To: "Gwen Shapira" X-ReviewRequest-Repository: kafka --===============7665594598673626190== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ ----------------------------------------------------------- (Updated Dec. 31, 2014, 12:01 a.m.) Review request for kafka. Bugs: KAFKA-1819 https://issues.apache.org/jira/browse/KAFKA-1819 Repository: kafka Description (updated) ------- added locking improved tests per Joel and Neha's suggestions added cleaner test to DeleteTopicTest Diffs (updated) ----- core/src/main/scala/kafka/log/LogCleaner.scala f8fcb843c80eec3cf3c931df6bb472c019305253 core/src/main/scala/kafka/log/LogCleanerManager.scala bcfef77ed53f94017c06a884e4db14531774a0a2 core/src/main/scala/kafka/log/LogManager.scala 4ebaae00ca4b80bf15c7930bae2011d98bbec053 core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 5bfa764638e92f217d0ff7108ec8f53193c22978 Diff: https://reviews.apache.org/r/29210/diff/ Testing ------- Thanks, Gwen Shapira --===============7665594598673626190==--