kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gwen Shapira" <gshap...@cloudera.com>
Subject Re: Review Request 29210: Patch for KAFKA-1819
Date Wed, 31 Dec 2014 00:02:31 GMT


> On Dec. 29, 2014, 10:14 p.m., Neha Narkhede wrote:
> > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala, line 75
> > <https://reviews.apache.org/r/29210/diff/2/?file=801625#file801625line75>
> >
> >     Gwen, I suggest adding this check (reading the checkpoint file and ensuring
that the entries related to the deleted topic are gone) to the DeleteTopicTest. 
> >     
> >     Rest of the patch looks good. We can check it in after this change

Thanks. Added a cleaner test to DeleteTopicTest.


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29210/#review66307
-----------------------------------------------------------


On Dec. 31, 2014, 12:01 a.m., Gwen Shapira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29210/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 12:01 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1819
>     https://issues.apache.org/jira/browse/KAFKA-1819
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> added locking
> 
> 
> improved tests per Joel and Neha's suggestions
> 
> 
> added cleaner test to DeleteTopicTest
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/log/LogCleaner.scala f8fcb843c80eec3cf3c931df6bb472c019305253

>   core/src/main/scala/kafka/log/LogCleanerManager.scala bcfef77ed53f94017c06a884e4db14531774a0a2

>   core/src/main/scala/kafka/log/LogManager.scala 4ebaae00ca4b80bf15c7930bae2011d98bbec053

>   core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc

>   core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 5bfa764638e92f217d0ff7108ec8f53193c22978

> 
> Diff: https://reviews.apache.org/r/29210/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gwen Shapira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message