kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gwen Shapira" <gshap...@cloudera.com>
Subject Re: Review Request 29231: Patch for KAFKA-1824
Date Tue, 23 Dec 2014 00:17:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29231/
-----------------------------------------------------------

(Updated Dec. 23, 2014, 12:17 a.m.)


Review request for kafka.


Bugs: KAFKA-1824
    https://issues.apache.org/jira/browse/KAFKA-1824


Repository: kafka


Description (updated)
-------

fixing accidental return of "WARN Property topic is not valid"


refactoring ConsoleProducer to allow testing and added unit tests


Diffs (updated)
-----

  core/src/main/scala/kafka/tools/ConsoleProducer.scala 1061cc74fac69693836f1e75add06b09d459a764

  core/src/test/scala/kafka/tools/ConsoleProducerTest.scala PRE-CREATION 

Diff: https://reviews.apache.org/r/29231/diff/


Testing
-------


Thanks,

Gwen Shapira


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message