kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrii Biletskyi" <andrii.bilets...@stealth.ly>
Subject Review Request 29301: Patch for KAFKA-1694
Date Mon, 22 Dec 2014 08:57:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29301/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1694
    https://issues.apache.org/jira/browse/KAFKA-1694


Repository: kafka


Description
-------

KAFKA-1694 - introduced new type for Wire protocol, ported ClusterMetadataResponse to it


KAFKA-1694 - Split Admin RQ/RP to separate messages


Diffs
-----

  bin/kafka.sh PRE-CREATION 
  bin/windows/kafka.bat PRE-CREATION 
  build.gradle 18f86e4c8a10618d50ac78572d119c6e100ed85b 
  clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java 109fc965e09b2ed186a073351bd037ac8af20a4c

  clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java 7517b879866fc5dad5f8d8ad30636da8bbe7784a

  clients/src/main/java/org/apache/kafka/common/protocol/types/MaybeOf.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java 121e880a941fcd3e6392859edba11a94236494cc

  clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataRequest.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/ClusterMetadataResponse.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/AlterTopicRequest.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/AlterTopicResponse.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/CreateTopicRequest.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/CreateTopicResponse.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/DeleteTopicRequest.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/DeleteTopicResponse.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/DescribeTopicOutput.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/DescribeTopicRequest.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/DescribeTopicResponse.java
PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/admin/ListTopicsOutput.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/ListTopicsRequest.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/ListTopicsResponse.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/TopicConfigDetails.java PRE-CREATION

  clients/src/main/java/org/apache/kafka/common/requests/admin/TopicPartitionsDetails.java
PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java df37fc6d8f0db0b8192a948426af603be3444da4

  core/src/main/scala/kafka/api/ApiUtils.scala 1f80de1638978901500df808ca5133308c9d1fca 
  core/src/main/scala/kafka/api/ClusterMetadataRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/ClusterMetadataResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43

  core/src/main/scala/kafka/api/admin/AlterTopicRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/AlterTopicResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/CreateTopicRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/CreateTopicResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/DeleteTopicRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/DeleteTopicResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/DescribeTopicRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/DescribeTopicResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/ListTopicsRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/ListTopicsResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/common/AdminRequestFailedException.scala PRE-CREATION 
  core/src/main/scala/kafka/common/ErrorMapping.scala eedc2f5f21dd8755fba891998456351622e17047

  core/src/main/scala/kafka/common/InvalidRequestTargetException.scala PRE-CREATION 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala eb492f00449744bc8d63f55b393e2a1659d38454

  core/src/main/scala/kafka/controller/KafkaController.scala 66df6d2fbdbdd556da6bea0df84f93e0472c8fbf

  core/src/main/scala/kafka/server/KafkaApis.scala 2a1c0326b6e6966d8b8254bd6a1cb83ad98a3b80

  core/src/main/scala/kafka/server/MetadataCache.scala bf81a1ab88c14be8697b441eedbeb28fa0112643

  core/src/main/scala/kafka/server/TopicCommandHelper.scala PRE-CREATION 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343

  settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45 
  tools/src/main/java/org/apache/kafka/cli/BaseCommandOpts.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/Boot.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/RequestDispatcher.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/Shell.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/AlterTopicCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/ClearScreenCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/Command.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/CreateTopicCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/DeleteTopicCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/DescribeTopicCommand.java PRE-CREATION

  tools/src/main/java/org/apache/kafka/cli/command/ExitCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/ListTopicsCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/PrintHelpCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/command/TopicSwitchCommand.java PRE-CREATION 
  tools/src/main/java/org/apache/kafka/cli/util/StringUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/29301/diff/


Testing
-------


Thanks,

Andrii Biletskyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message