kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gwen Shapira" <gshap...@cloudera.com>
Subject Re: Review Request 28859: Patch for KAFKA-1812
Date Thu, 11 Dec 2014 04:12:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28859/#review64689
-----------------------------------------------------------

Ship it!


Non-binding +1

- Gwen Shapira


On Dec. 11, 2014, 2:39 a.m., Jeff Holoman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28859/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 2:39 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1812
>     https://issues.apache.org/jira/browse/KAFKA-1812
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1812 Updated based on rb comments
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/utils/Utils.scala 58685cc47b4c43e4ee68b73f1ee34eb99a5aa547

>   core/src/test/scala/unit/kafka/utils/UtilsTest.scala 0d0f0e2fba367180eeb718a259e8d680a73c3a73

> 
> Diff: https://reviews.apache.org/r/28859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff Holoman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message