kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrii Biletskyi" <andrii.bilets...@stealth.ly>
Subject Re: Review Request 28175: Patch for KAFKA-1772
Date Tue, 02 Dec 2014 14:23:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28175/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 2:23 p.m.)


Review request for kafka.


Bugs: KAFKA-1772
    https://issues.apache.org/jira/browse/KAFKA-1772


Repository: kafka


Description (updated)
-------

KAFKA-1772 -  Review fixes: removed format field; added NetworkClient part for Admin RQ/RP


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java 109fc965e09b2ed186a073351bd037ac8af20a4c

  clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java 7517b879866fc5dad5f8d8ad30636da8bbe7784a

  clients/src/main/java/org/apache/kafka/common/requests/AdminRequest.java PRE-CREATION 
  clients/src/main/java/org/apache/kafka/common/requests/AdminResponse.java PRE-CREATION 
  clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java df37fc6d8f0db0b8192a948426af603be3444da4

  core/src/main/scala/kafka/api/AdminRequest.scala PRE-CREATION 
  core/src/main/scala/kafka/api/AdminResponse.scala PRE-CREATION 
  core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43

  core/src/main/scala/kafka/api/admin/request/args/ParseException.scala PRE-CREATION 
  core/src/main/scala/kafka/api/admin/request/args/TopicCommandArguments.scala PRE-CREATION

  core/src/main/scala/kafka/common/AdminRequestFailedException.scala PRE-CREATION 
  core/src/main/scala/kafka/common/ErrorMapping.scala eedc2f5f21dd8755fba891998456351622e17047

  core/src/test/scala/unit/kafka/api/AdminRequestTest.scala PRE-CREATION 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343


Diff: https://reviews.apache.org/r/28175/diff/


Testing
-------


Thanks,

Andrii Biletskyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message