Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Mon, 3 Nov 2014 19:47:34 +0000 (UTC)
From: "Ewen Cheslack-Postava (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12752504.1415043919000.401073.1415044054095@Atlassian.JIRA>
In-Reply-To: <JIRA.12752504.1415043919000@Atlassian.JIRA>
References: <JIRA.12752504.1415043919000@Atlassian.JIRA>
 <JIRA.12752504.1415043919059@arcas>
Subject: [jira] [Commented] (KAFKA-1747) TestcaseEnv improperly shares state
 between instances
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KAFKA-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194984#comment-14194984 ] 

Ewen Cheslack-Postava commented on KAFKA-1747:
----------------------------------------------

Created reviewboard https://reviews.apache.org/r/27535/diff/
 against branch origin/trunk

> TestcaseEnv improperly shares state between instances
> -----------------------------------------------------
>
>                 Key: KAFKA-1747
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1747
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.1.1
>            Reporter: Ewen Cheslack-Postava
>         Attachments: KAFKA-1747.patch
>
>
> TestcaseEnv in system tests uses class variables instead of instance variables for a bunch of state. This causes the data to persist between tests. In some cases this can cause tests to break (e.g. there will be state from a service running in a previous test that doesn't exist in the current test; trying to look up state about that service raises an exception or produces invalid data).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)