Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7264C1024E for ; Tue, 18 Nov 2014 05:30:34 +0000 (UTC) Received: (qmail 47446 invoked by uid 500); 18 Nov 2014 05:30:34 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 47379 invoked by uid 500); 18 Nov 2014 05:30:34 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 47106 invoked by uid 99); 18 Nov 2014 05:30:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 05:30:34 +0000 Date: Tue, 18 Nov 2014 05:30:33 +0000 (UTC) From: "Manikumar Reddy (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215733#comment-14215733 ] Manikumar Reddy commented on KAFKA-1743: ---------------------------------------- Updated reviewboard https://reviews.apache.org/r/27684/diff/ against branch origin/0.8.2 > ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible > ------------------------------------------------------------------- > > Key: KAFKA-1743 > URL: https://issues.apache.org/jira/browse/KAFKA-1743 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.8.2 > Reporter: Jun Rao > Assignee: Manikumar Reddy > Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1743.patch, KAFKA-1743_2014-11-08_11:49:31.patch, KAFKA-1743_2014-11-14_22:29:21.patch, KAFKA-1743_2014-11-16_12:11:51.patch, KAFKA-1743_2014-11-18_10:59:05.patch > > > In 0.8.1.x, ConsumerConnector has the following api: > def commitOffsets > This is changed to the following in 0.8.2 and breaks compatibility > def commitOffsets(retryOnFailure: Boolean = true) -- This message was sent by Atlassian JIRA (v6.3.4#6332)