Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A8B6B10BBE for ; Tue, 25 Nov 2014 02:18:09 +0000 (UTC) Received: (qmail 74783 invoked by uid 500); 25 Nov 2014 02:18:09 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 74733 invoked by uid 500); 25 Nov 2014 02:18:09 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 74720 invoked by uid 99); 25 Nov 2014 02:18:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Nov 2014 02:18:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DF05067CDA; Tue, 25 Nov 2014 02:18:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3825469639042841669==" MIME-Version: 1.0 Subject: Re: Review Request 28121: Patch for KAFKA-1780 From: "Neha Narkhede" To: "Ewen Cheslack-Postava" , "Neha Narkhede" , "kafka" Date: Tue, 25 Nov 2014 02:18:07 -0000 Message-ID: <20141125021807.15978.58061@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Neha Narkhede" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/28121/ X-Sender: "Neha Narkhede" References: <20141125012457.15977.29412@reviews.apache.org> In-Reply-To: <20141125012457.15977.29412@reviews.apache.org> Reply-To: "Neha Narkhede" X-ReviewRequest-Repository: kafka --===============3825469639042841669== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28121/#review62926 ----------------------------------------------------------- Ship it! - Neha Narkhede On Nov. 25, 2014, 1:24 a.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28121/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 1:24 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1780 > https://issues.apache.org/jira/browse/KAFKA-1780 > > > Repository: kafka > > > Description > ------- > > Expand documentation on ConsumerIterator to reflect new non-blocking APIs. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerIterator.scala 78fbf75651583e390258af2d9f09df6911a97b59 > core/src/main/scala/kafka/utils/IteratorTemplate.scala fd952f3ec0f04a3ba639c02779634265489fd186 > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala c0355cc0135c6af2e346b4715659353a31723b86 > core/src/test/scala/unit/kafka/utils/IteratorTemplateTest.scala 46a4e899ef293c56a931bfa5bcf9a07d07ec5792 > > Diff: https://reviews.apache.org/r/28121/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > > --===============3825469639042841669==--