Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0BB110248 for ; Tue, 18 Nov 2014 05:29:54 +0000 (UTC) Received: (qmail 45754 invoked by uid 500); 18 Nov 2014 05:29:54 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 45706 invoked by uid 500); 18 Nov 2014 05:29:54 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 45689 invoked by uid 99); 18 Nov 2014 05:29:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Nov 2014 05:29:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9D3D71DF2D0; Tue, 18 Nov 2014 05:29:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4621843053958852631==" MIME-Version: 1.0 Subject: Re: Review Request 27684: Patch for KAFKA-1743 From: "Manikumar Reddy O" To: "kafka" , "Jun Rao" , "Manikumar Reddy O" , "Joel Koshy" , "Gwen Shapira" Date: Tue, 18 Nov 2014 05:29:53 -0000 Message-ID: <20141118052953.24716.62129@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Manikumar Reddy O" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/27684/ X-Sender: "Manikumar Reddy O" References: <20141116064234.24717.67348@reviews.apache.org> In-Reply-To: <20141116064234.24717.67348@reviews.apache.org> Reply-To: "Manikumar Reddy O" X-ReviewRequest-Repository: kafka --===============4621843053958852631== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ ----------------------------------------------------------- (Updated Nov. 18, 2014, 5:29 a.m.) Review request for kafka. Bugs: KAFKA-1743 https://issues.apache.org/jira/browse/KAFKA-1743 Repository: kafka Description ------- def commitOffsets method added to make ConsumerConnector backward compatible; Addressing Jun's comments Diffs (updated) ----- core/src/main/scala/kafka/consumer/ConsumerConnector.scala 07677c1c26768ef9c9032626180d0015f12cb0e0 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fe9d8e028cf08db844f0d72de4dd1e78f0e4258c core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala 1f98db5d692adc113189ec8c75a4fad29d6b6ffe core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala bad099a904967651bc3a38b6bb9a9cdb592b832b Diff: https://reviews.apache.org/r/27684/diff/ Testing ------- Thanks, Manikumar Reddy O --===============4621843053958852631==--