Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 778C1F4C9 for ; Fri, 14 Nov 2014 17:00:08 +0000 (UTC) Received: (qmail 11895 invoked by uid 500); 14 Nov 2014 17:00:08 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 11848 invoked by uid 500); 14 Nov 2014 17:00:08 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 11831 invoked by uid 99); 14 Nov 2014 17:00:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Nov 2014 17:00:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7E2E011573F; Fri, 14 Nov 2014 17:00:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4810623453960604207==" MIME-Version: 1.0 Subject: Re: Review Request 27684: Patch for KAFKA-1743 From: "Manikumar Reddy O" To: "kafka" , "Jun Rao" , "Manikumar Reddy O" , "Joel Koshy" , "Gwen Shapira" Date: Fri, 14 Nov 2014 17:00:07 -0000 Message-ID: <20141114170007.1251.42163@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Manikumar Reddy O" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/27684/ X-Sender: "Manikumar Reddy O" References: <20141108062013.10454.66964@reviews.apache.org> In-Reply-To: <20141108062013.10454.66964@reviews.apache.org> Reply-To: "Manikumar Reddy O" X-ReviewRequest-Repository: kafka --===============4810623453960604207== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ ----------------------------------------------------------- (Updated Nov. 14, 2014, 5 p.m.) Review request for kafka. Bugs: KAFKA-1743 https://issues.apache.org/jira/browse/KAFKA-1743 Repository: kafka Description (updated) ------- def commitOffsets method added to make ConsumerConnector backward compatible; Adressing Jun's comments Diffs (updated) ----- core/src/main/scala/kafka/consumer/ConsumerConnector.scala 07677c1c26768ef9c9032626180d0015f12cb0e0 Diff: https://reviews.apache.org/r/27684/diff/ Testing ------- Thanks, Manikumar Reddy O --===============4810623453960604207==--