Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B75AF1769D for ; Sat, 8 Nov 2014 06:20:10 +0000 (UTC) Received: (qmail 15813 invoked by uid 500); 8 Nov 2014 06:20:10 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 15756 invoked by uid 500); 8 Nov 2014 06:20:10 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 15739 invoked by uid 99); 8 Nov 2014 06:20:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Nov 2014 06:20:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8F2991DFD4D; Sat, 8 Nov 2014 06:20:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2638575987629148897==" MIME-Version: 1.0 Subject: Re: Review Request 27684: Patch for KAFKA-1743 From: "Manikumar Reddy O" To: "kafka" , "Manikumar Reddy O" , "Joel Koshy" , "Gwen Shapira" Date: Sat, 08 Nov 2014 06:20:13 -0000 Message-ID: <20141108062013.10454.66964@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Manikumar Reddy O" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/27684/ X-Sender: "Manikumar Reddy O" References: <20141106171302.10454.21713@reviews.apache.org> In-Reply-To: <20141106171302.10454.21713@reviews.apache.org> Reply-To: "Manikumar Reddy O" X-ReviewRequest-Repository: kafka --===============2638575987629148897== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ ----------------------------------------------------------- (Updated Nov. 8, 2014, 6:20 a.m.) Review request for kafka. Bugs: KAFKA-1743 https://issues.apache.org/jira/browse/KAFKA-1743 Repository: kafka Description ------- def commitOffsets method added to make ConsumerConnector backward compatible Diffs (updated) ----- core/src/main/scala/kafka/consumer/ConsumerConnector.scala 07677c1c26768ef9c9032626180d0015f12cb0e0 Diff: https://reviews.apache.org/r/27684/diff/ Testing ------- Thanks, Manikumar Reddy O --===============2638575987629148897==--