Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E77517A0C for ; Thu, 6 Nov 2014 17:12:59 +0000 (UTC) Received: (qmail 34987 invoked by uid 500); 6 Nov 2014 17:12:58 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 34940 invoked by uid 500); 6 Nov 2014 17:12:58 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 34922 invoked by uid 99); 6 Nov 2014 17:12:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 17:12:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 139871DFC2A; Thu, 6 Nov 2014 17:13:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6326943419972195538==" MIME-Version: 1.0 Subject: Review Request 27684: Patch for KAFKA-1743 From: "Manikumar Reddy O" To: "kafka" , "Manikumar Reddy O" Date: Thu, 06 Nov 2014 17:13:02 -0000 Message-ID: <20141106171302.10454.21713@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Manikumar Reddy O" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/27684/ X-Sender: "Manikumar Reddy O" Reply-To: "Manikumar Reddy O" X-ReviewRequest-Repository: kafka --===============6326943419972195538== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ ----------------------------------------------------------- Review request for kafka. Bugs: KAFKA-1743 https://issues.apache.org/jira/browse/KAFKA-1743 Repository: kafka Description ------- def commitOffsets method added to make ConsumerConnector backward compatible Diffs ----- core/src/main/scala/kafka/consumer/ConsumerConnector.scala 07677c1c26768ef9c9032626180d0015f12cb0e0 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b Diff: https://reviews.apache.org/r/27684/diff/ Testing ------- Thanks, Manikumar Reddy O --===============6326943419972195538==--