Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F0CFA1755C for ; Sat, 1 Nov 2014 02:37:28 +0000 (UTC) Received: (qmail 726 invoked by uid 500); 1 Nov 2014 02:37:28 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 679 invoked by uid 500); 1 Nov 2014 02:37:28 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 666 invoked by uid 99); 1 Nov 2014 02:37:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Nov 2014 02:37:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4930B1DFA79; Sat, 1 Nov 2014 02:37:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3317692885165035261==" MIME-Version: 1.0 Subject: Re: Review Request 27430: Fix KAFKA-1720 From: "Gwen Shapira" To: "kafka" , "Gwen Shapira" , "Guozhang Wang" Date: Sat, 01 Nov 2014 02:37:32 -0000 Message-ID: <20141101023732.7138.75947@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gwen Shapira" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/27430/ X-Sender: "Gwen Shapira" References: <20141101002157.7137.76041@reviews.apache.org> In-Reply-To: <20141101002157.7137.76041@reviews.apache.org> Reply-To: "Gwen Shapira" X-ReviewRequest-Repository: kafka --===============3317692885165035261== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/#review59453 ----------------------------------------------------------- Ship it! LGTM :) - Gwen Shapira On Nov. 1, 2014, 12:21 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27430/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2014, 12:21 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1720 > https://issues.apache.org/jira/browse/KAFKA-1720 > > > Repository: kafka > > > Description > ------- > > Rename delayed requests to delayed operations, change some class names > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala 1be57008e983fc3a831626ecf9a861f164fcca92 > core/src/main/scala/kafka/server/DelayedFetch.scala 1ccbb4b6fdbbd4412ba77ffe7d4cf5adf939e439 > core/src/main/scala/kafka/server/DelayedProduce.scala 8049e07e5d6d65913ec2492f1e22e5ed3ecbbea8 > core/src/main/scala/kafka/server/DelayedRequestKey.scala 628ef59564b9b9238d7b05d26aef79d3cfec174d > core/src/main/scala/kafka/server/ReplicaManager.scala 3007a6d89b637b93f71fdb7adab561a93d9c4c62 > core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada > core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e > system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4 > > Diff: https://reviews.apache.org/r/27430/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > > --===============3317692885165035261==--