kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 26474: KAFKA-1654 Provide a way to override server configuration from command line
Date Mon, 24 Nov 2014 00:36:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26474/#review62746
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Nov. 23, 2014, 5:40 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26474/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2014, 5:40 p.m.)
> 
> 
> Review request for kafka and Neha Narkhede.
> 
> 
> Bugs: SQOOP-1654
>     https://issues.apache.org/jira/browse/SQOOP-1654
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> I'm assuming that we might want to add additional arguments in the future as well, so
I've added general facility to parse arguments to Kafka main class and added argument --set
that defines/overrides any property in the config file. I've decided to use --set rather then
exposing each property that is availalbe in KafkaConfig class as it's own argument, so that
we don't have to keep those two classes always in sync.
> 
> This is first "bigger" patch that I've written in Scala, so I'm particularly interested
to hear feedback on the coding style.
> 
> 
> Diffs
> -----
> 
>   bin/kafka-server-start.sh 1737d0c 
>   core/src/main/scala/kafka/Kafka.scala 2e94fee 
>   core/src/test/scala/unit/kafka/KafkaTest.scala PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26474/diff/
> 
> 
> Testing
> -------
> 
> I've added unit tests and verified the functionality on real "cluster".
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message