kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 23702: Patch for KAFKA-1070
Date Sun, 23 Nov 2014 20:35:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23702/#review62737
-----------------------------------------------------------



core/src/main/scala/kafka/common/GenerateBrokerIdException.scala
<https://reviews.apache.org/r/23702/#comment104816>

    Given InconsistentBrokerIdException, looks like we don't need this.



core/src/main/scala/kafka/server/KafkaConfig.scala
<https://reviews.apache.org/r/23702/#comment104817>

    Why do we need a policy? It looks like we are trying to design the automatic broker id
assignment around a few people who have hacked it by using the IP. It is worth doing the right
thing and having a few people reconfigure their setup to use the sequence.



core/src/main/scala/kafka/server/KafkaServer.scala
<https://reviews.apache.org/r/23702/#comment104820>

    failed -> Failed
    configured -> Configured.
    
    Similarly can you also fix all the API description comments?



core/src/main/scala/kafka/server/KafkaServer.scala
<https://reviews.apache.org/r/23702/#comment104823>

    This file needs to be versioned to make future format changes feasible. Look at OffsetCheckpoint
for an example.



core/src/main/scala/kafka/utils/ZkUtils.scala
<https://reviews.apache.org/r/23702/#comment104818>

    Why not use persistent sequential nodes instead?



core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala
<https://reviews.apache.org/r/23702/#comment104819>

    Typo: Genrated


- Neha Narkhede


On Nov. 20, 2014, 6:50 p.m., Sriharsha Chintalapani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23702/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2014, 6:50 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1070
>     https://issues.apache.org/jira/browse/KAFKA-1070
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1070. Auto-assign node id.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/common/GenerateBrokerIdException.scala PRE-CREATION 
>   core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala PRE-CREATION 
>   core/src/main/scala/kafka/server/KafkaConfig.scala 6e26c5436feb4629d17f199011f3ebb674aa767f

>   core/src/main/scala/kafka/server/KafkaServer.scala 1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe

>   core/src/main/scala/kafka/utils/Utils.scala 23aefb4715b177feae1d2f83e8b910653ea10c5f

>   core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd

>   core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala PRE-CREATION

>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 0da774d0ed015bdc0461b854e3540ee6e48d1838

> 
> Diff: https://reviews.apache.org/r/23702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message