kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singh" <asi...@cloudera.com>
Subject Re: Review Request 28108: KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
Date Sun, 23 Nov 2014 05:38:44 GMT


> On Nov. 20, 2014, 2:01 p.m., Gwen Shapira wrote:
> > We have multiple functions for creating znodes in ZkUtils. persistent, epehmeral,
sequence, etc...
> > 
> > Does it make sense to put the validation in a function and use it in all "create"
functions?

Thanks for the review Gwen. Added a class to wrap zk path creations and updated all instances
of path creation in ZkUtils to use the new class.


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28108/#review62349
-----------------------------------------------------------


On Nov. 23, 2014, 5:37 a.m., Ashish Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28108/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2014, 5:37 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1664: Kafka does not properly parse multiple ZK nodes with non-root chroot
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd

> 
> Diff: https://reviews.apache.org/r/28108/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without the fix.
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message