kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manikumar Reddy O" <manikumar.re...@gmail.com>
Subject Re: Review Request 27684: Patch for KAFKA-1743
Date Tue, 18 Nov 2014 05:34:48 GMT


> On Nov. 18, 2014, 2:49 a.m., Jun Rao wrote:
> > Thanks for the patch. Got the following compilation error.
> > 
> > :core:compileTestScala/Users/junrao/intellij/kafka/core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala:116:
overloaded method value commitOffsets with alternatives:
> >   => Unit <and>
> >   (isAutoCommit: Boolean)Unit
> >  cannot be applied to ()
> >     zkConsumerConnector1.commitOffsets()
> >                          ^
> > /Users/junrao/intellij/kafka/core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala:204:
overloaded method value commitOffsets with alternatives:
> >   => Unit <and>
> >   (isAutoCommit: Boolean)Unit
> >  cannot be applied to ()
> >     zkConsumerConnector1.commitOffsets()
> >                          ^
> > two errors found
> >  FAILED

Oh My Bad!  missed the test classes. Pl review the latest patch.


- Manikumar Reddy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27684/#review61863
-----------------------------------------------------------


On Nov. 18, 2014, 5:29 a.m., Manikumar Reddy O wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27684/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 5:29 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1743
>     https://issues.apache.org/jira/browse/KAFKA-1743
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> def commitOffsets method added to make ConsumerConnector backward  compatible; Addressing
Jun's comments
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/consumer/ConsumerConnector.scala 07677c1c26768ef9c9032626180d0015f12cb0e0

>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fe9d8e028cf08db844f0d72de4dd1e78f0e4258c

>   core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala 1f98db5d692adc113189ec8c75a4fad29d6b6ffe

>   core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala bad099a904967651bc3a38b6bb9a9cdb592b832b

> 
> Diff: https://reviews.apache.org/r/27684/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manikumar Reddy O
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message