kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 27818: Patch for KAFKA-328
Date Fri, 14 Nov 2014 19:31:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27818/#review61488
-----------------------------------------------------------



core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
<https://reviews.apache.org/r/27818/#comment103149>

    Let's follow the convention and change this to fail()


- Neha Narkhede


On Nov. 10, 2014, 6:05 p.m., Balaji Seshadri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27818/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 6:05 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-328
>     https://issues.apache.org/jira/browse/KAFKA-328
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-328 Write unit test for kafka server startup and shutdown API - Review Comments
> 
> 
> Diffs
> -----
> 
>   core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 1bfb501b2f29c50f3fc5f930fdaad02e03b91e4f

>   core/src/test/scala/unit/kafka/server/ServerStartupTest.scala a0ed4855f2550a0eb2e363dd2fccd8377a9ac172

> 
> Diff: https://reviews.apache.org/r/27818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Balaji Seshadri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message