kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 27693: Patch for KAFKA-1476
Date Mon, 10 Nov 2014 03:58:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27693/#review60537
-----------------------------------------------------------



core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment101912>

    list-group if you change the next one to describe-group



core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment101911>

    describeGroup->describe-group or just describe
    
    Also please update the doc with exactly what information the describe will give the user



core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment101913>

    we'd rather than in a generic property list. Please look at other tools for an example.
(kafka-topics.sh)



core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment101914>

    Could you please refactor the rest of the tool such that every operation is in it's own
function. Here is an example from the topics tool
    
        try {
          if(opts.options.has(opts.createOpt))
            createTopic(zkClient, opts)
          else if(opts.options.has(opts.alterOpt))
            alterTopic(zkClient, opts)
          else if(opts.options.has(opts.listOpt))
            listTopics(zkClient, opts)
          else if(opts.options.has(opts.describeOpt))
            describeTopic(zkClient, opts)
          else if(opts.options.has(opts.deleteOpt))
            deleteTopic(zkClient, opts)
        } catch {
          case e: Throwable =>
            println("Error while executing topic command " + e.getMessage)
            println(Utils.stackTrace(e))
        } finally {
          zkClient.close()
        }
      }



core/src/main/scala/kafka/tools/ConsumerCommand.scala
<https://reviews.apache.org/r/27693/#comment101915>

    offsetMap1->offsetMap


- Neha Narkhede


On Nov. 6, 2014, 6:11 p.m., Balaji Seshadri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27693/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 6:11 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1476
>     https://issues.apache.org/jira/browse/KAFKA-1476
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1476 Get list of consumer groups
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/ConsumerCommand.scala PRE-CREATION 
>   core/src/main/scala/kafka/utils/ZkUtils.scala 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd

> 
> Diff: https://reviews.apache.org/r/27693/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Balaji Seshadri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message