Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA25D17BB1 for ; Wed, 1 Oct 2014 06:22:01 +0000 (UTC) Received: (qmail 1800 invoked by uid 500); 1 Oct 2014 06:21:55 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 1757 invoked by uid 500); 1 Oct 2014 06:21:55 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 1584 invoked by uid 99); 1 Oct 2014 06:21:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 06:21:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 86E0C1DDBB4; Wed, 1 Oct 2014 06:21:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2641407571241822799==" MIME-Version: 1.0 Subject: Re: Review Request 25136: Patch for KAFKA-1610 From: "Mayuresh Gharat" To: "Mayuresh Gharat" , "Guozhang Wang" , "Neha Narkhede" , "Joel Koshy" , "kafka" Date: Wed, 01 Oct 2014 06:21:51 -0000 Message-ID: <20141001062151.19177.88338@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mayuresh Gharat" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/25136/ X-Sender: "Mayuresh Gharat" References: <20140916222328.7803.12139@reviews.apache.org> In-Reply-To: <20140916222328.7803.12139@reviews.apache.org> Reply-To: "Mayuresh Gharat" X-ReviewRequest-Repository: kafka --===============2641407571241822799== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25136/ ----------------------------------------------------------- (Updated Oct. 1, 2014, 6:21 a.m.) Review request for kafka. Bugs: KAFKA-1610 https://issues.apache.org/jira/browse/KAFKA-1610 Repository: kafka Description (updated) ------- Reverting the changes and adding comments to make the usage of mapValues more clear Formatted the comments Removed comments and changed variable names as per the reviews Removed comments and changed variable names as per the reviews Diffs (updated) ----- core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 691d69a49a240f38883d2025afaec26fd61281b5 core/src/main/scala/kafka/controller/KafkaController.scala 8ab4a1b8072c9dd187a9a6e94138b725d1f1b153 core/src/main/scala/kafka/server/DelayedFetch.scala e0f14e25af03e6d4344386dcabc1457ee784d345 core/src/main/scala/kafka/server/DelayedProduce.scala 9481508fc2d6140b36829840c337e557f3d090da core/src/main/scala/kafka/server/KafkaApis.scala c584b559416b3ee4bcbec5966be4891e0a03eefb core/src/main/scala/kafka/server/KafkaServer.scala 3e9e91f2b456bbdeb3055d571e18ffea8675b4bf core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ba6ddd7a909df79a0f7d45e8b4a2af94ea0fceb6 core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e Diff: https://reviews.apache.org/r/25136/diff/ Testing ------- Ran the unit tests and everything passed and the build succeeeded Thanks, Mayuresh Gharat --===============2641407571241822799==--