Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 001E010AC4 for ; Wed, 19 Mar 2014 00:18:28 +0000 (UTC) Received: (qmail 97117 invoked by uid 500); 19 Mar 2014 00:18:25 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 97077 invoked by uid 500); 19 Mar 2014 00:18:17 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 96919 invoked by uid 99); 19 Mar 2014 00:18:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Mar 2014 00:18:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 80C7F1D54D2; Wed, 19 Mar 2014 00:18:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2961539483963452695==" MIME-Version: 1.0 Subject: Re: Review Request 19379: Patch for KAFKA-1311 From: "Timothy Chen" To: "kafka" , "Timothy Chen" , "Neha Narkhede" Date: Wed, 19 Mar 2014 00:18:05 -0000 Message-ID: <20140319001805.17334.20336@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/19379/ X-Sender: "Timothy Chen" References: <20140319001435.17334.72018@reviews.apache.org> In-Reply-To: <20140319001435.17334.72018@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: kafka --===============2961539483963452695== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/#review37668 ----------------------------------------------------------- Ship it! Ship It! - Timothy Chen On March 19, 2014, 12:14 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19379/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 12:14 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1311 > https://issues.apache.org/jira/browse/KAFKA-1311 > > > Repository: kafka > > > Description > ------- > > Joel's review comments > > > 1. Removed --delete from topic command 2. Added config to turn off delete topic (delete.topic.enable) > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala 6fef9df19fbc7caf90d0409bffd36fea1f4c4da5 > core/src/main/scala/kafka/controller/PartitionStateMachine.scala c69077e6f4dc04232f63d748aa4e49d33d0cebc4 > core/src/main/scala/kafka/controller/TopicDeletionManager.scala 58f1c4274e9f8ec3f4711974eae0588020c5c169 > core/src/main/scala/kafka/server/KafkaConfig.scala 08de0eff67311e25d56d4133882faea6758c977c > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 6db76a53173aab06b84203712c98313ce1e8b12e > > Diff: https://reviews.apache.org/r/19379/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > > --===============2961539483963452695==--