Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24A531078B for ; Tue, 18 Mar 2014 22:32:58 +0000 (UTC) Received: (qmail 3367 invoked by uid 500); 18 Mar 2014 22:32:57 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 3338 invoked by uid 500); 18 Mar 2014 22:32:57 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 3329 invoked by uid 99); 18 Mar 2014 22:32:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 22:32:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 844CE1D54D2; Tue, 18 Mar 2014 22:32:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3085274051630215935==" MIME-Version: 1.0 Subject: Re: Review Request 19379: Patch for KAFKA-1311 From: "Neha Narkhede" To: "kafka" , "Neha Narkhede" Date: Tue, 18 Mar 2014 22:32:54 -0000 Message-ID: <20140318223254.15795.88657@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Neha Narkhede" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/19379/ X-Sender: "Neha Narkhede" References: <20140318223013.27430.20551@reviews.apache.org> In-Reply-To: <20140318223013.27430.20551@reviews.apache.org> Reply-To: "Neha Narkhede" X-ReviewRequest-Repository: kafka --===============3085274051630215935== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19379/ ----------------------------------------------------------- (Updated March 18, 2014, 10:32 p.m.) Review request for kafka. Bugs: KAFKA-1311 https://issues.apache.org/jira/browse/KAFKA-1311 Repository: kafka Description (updated) ------- 1. Removed --delete from topic command 2. Added config to turn off delete topic (delete.topic.enable) The reason I chose protecting all public APIs of TopicDeletionManager instead of protecting everything that calls those APIs is only to contain the change. It will be a more widespread and hence risky change to do the latter. Let me know if people think otherwise. Diffs ----- core/src/main/scala/kafka/admin/TopicCommand.scala 6fef9df19fbc7caf90d0409bffd36fea1f4c4da5 core/src/main/scala/kafka/controller/PartitionStateMachine.scala c69077e6f4dc04232f63d748aa4e49d33d0cebc4 core/src/main/scala/kafka/controller/TopicDeletionManager.scala 58f1c4274e9f8ec3f4711974eae0588020c5c169 core/src/main/scala/kafka/server/KafkaConfig.scala 08de0eff67311e25d56d4133882faea6758c977c core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 6db76a53173aab06b84203712c98313ce1e8b12e Diff: https://reviews.apache.org/r/19379/diff/ Testing ------- Thanks, Neha Narkhede --===============3085274051630215935==--