Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2CD9C10600 for ; Tue, 18 Mar 2014 16:53:15 +0000 (UTC) Received: (qmail 66159 invoked by uid 500); 18 Mar 2014 16:53:14 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 65882 invoked by uid 500); 18 Mar 2014 16:53:13 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 65862 invoked by uid 99); 18 Mar 2014 16:53:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 16:53:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A8B771D54CC; Tue, 18 Mar 2014 16:53:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7367168139586622263==" MIME-Version: 1.0 Subject: Re: Review Request 19311: Patch for KAFKA-1307 From: "Jun Rao" To: "kafka" , "Jun Rao" , "Neha Narkhede" , "Guozhang Wang" , "Jay Kreps" Date: Tue, 18 Mar 2014 16:53:08 -0000 Message-ID: <20140318165308.17334.58614@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jun Rao" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/19311/ X-Sender: "Jun Rao" References: <20140317171147.17328.30811@reviews.apache.org> In-Reply-To: <20140317171147.17328.30811@reviews.apache.org> Reply-To: "Jun Rao" X-ReviewRequest-Repository: kafka --===============7367168139586622263== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19311/ ----------------------------------------------------------- (Updated March 18, 2014, 4:53 p.m.) Review request for kafka. Bugs: KAFKA-1307 https://issues.apache.org/jira/browse/KAFKA-1307 Repository: kafka Description (updated) ------- convert UnresolvedAddressException to IOException in Selector Fixed the issues listed in the jira. Diffs (updated) ----- clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java 5bed60730ea108684bea2440af5a008feb0ada61 clients/src/main/java/org/apache/kafka/clients/producer/internals/ErrorLoggingCallback.java 368e8f3b249e3d640240c73cd5ab1ad047b60aa7 clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java db6e3a1842bfd034d55311f875afe7d7a97dfec5 clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java 7a03f389cc6a4d56152b882555d7498af9a04d20 clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java c989e251f6ecbe01a1daaf84dbe7147ec686afa1 clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java 61257d1ac6ee3db8f6824617d6e35e8527f1b62a clients/src/main/java/org/apache/kafka/common/network/Selector.java f83189d3ce4169523e40a5631435fcf59777d7fb clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java dc03fd04c981dfac7f16f61c9cbfa7f1f4c324c8 clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 865996c1fb5d8852db26c8618203a1d6429625d2 core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala 6f9054953392807a901301d72ee7ab107a09ad84 perf/src/main/scala/kafka/perf/ProducerPerformance.scala f12a45becb11a8bed586024866235b268630fec6 Diff: https://reviews.apache.org/r/19311/diff/ Testing ------- Thanks, Jun Rao --===============7367168139586622263==--