Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5502E10121 for ; Tue, 18 Mar 2014 15:04:33 +0000 (UTC) Received: (qmail 1616 invoked by uid 500); 18 Mar 2014 15:04:08 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 1366 invoked by uid 500); 18 Mar 2014 15:04:01 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 1071 invoked by uid 99); 18 Mar 2014 15:03:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 15:03:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7D7AF1D54CC; Tue, 18 Mar 2014 15:03:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5993499464085641603==" MIME-Version: 1.0 Subject: Re: Review Request 19338: Patch for KAFKA-1309 From: "Neha Narkhede" To: "joel koshy" , "Neha Narkhede" , "kafka" Date: Tue, 18 Mar 2014 15:03:52 -0000 Message-ID: <20140318150352.27430.11705@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Neha Narkhede" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/19338/ X-Sender: "Neha Narkhede" References: <20140318075328.17334.81403@reviews.apache.org> In-Reply-To: <20140318075328.17334.81403@reviews.apache.org> Reply-To: "Neha Narkhede" X-ReviewRequest-Repository: kafka --===============5993499464085641603== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19338/#review37555 ----------------------------------------------------------- Ship it! Ship It! - Neha Narkhede On March 18, 2014, 7:53 a.m., joel koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19338/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 7:53 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1309 > https://issues.apache.org/jira/browse/KAFKA-1309 > > > Repository: kafka > > > Description > ------- > > fix > > > Diffs > ----- > > core/src/main/scala/kafka/api/OffsetCommitRequest.scala 9f6956e97b5e53fe91a323f1ee49ea95b8476348 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 9a3db904915f2874b1ba223d7ed01d497421a846 > core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 6de320dcc0d9373dd046bda0ea68a9c9f8931630 > core/src/test/scala/other/kafka/TestOffsetManager.scala 83317f07611b6877bbeb62a5ef34f8d31bf978d7 > core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 53784466149569a4d4dc039e079c4e92c80ff0d1 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala e63299762dcfec47c2957dd46a833c430fee591a > > Diff: https://reviews.apache.org/r/19338/diff/ > > > Testing > ------- > > > Thanks, > > joel koshy > > --===============5993499464085641603==--