Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B08F10BD5 for ; Tue, 4 Mar 2014 23:15:57 +0000 (UTC) Received: (qmail 19485 invoked by uid 500); 4 Mar 2014 23:15:43 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 19455 invoked by uid 500); 4 Mar 2014 23:15:42 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 19445 invoked by uid 99); 4 Mar 2014 23:15:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Mar 2014 23:15:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 24F461D4BAE; Tue, 4 Mar 2014 23:15:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5150425235684109181==" MIME-Version: 1.0 Subject: Re: Review Request 18740: Fix KAFKA-1286 From: "Guozhang Wang" To: "kafka" , "Jay Kreps" , "Guozhang Wang" Date: Tue, 04 Mar 2014 23:15:41 -0000 Message-ID: <20140304231541.6955.41389@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Guozhang Wang" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/18740/ X-Sender: "Guozhang Wang" References: <20140304231503.6955.1233@reviews.apache.org> In-Reply-To: <20140304231503.6955.1233@reviews.apache.org> Reply-To: "Guozhang Wang" X-ReviewRequest-Repository: kafka --===============5150425235684109181== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ ----------------------------------------------------------- (Updated March 4, 2014, 11:15 p.m.) Review request for kafka. Bugs: KAFKA-1286 https://issues.apache.org/jira/browse/KAFKA-1286 Repository: kafka Description (updated) ------- Incorporated Jay's comments. 1. Fix the metadata-in-progree flag issue. 2. Add backoff config for retry. 3. Some logging level changes. 4. Fix a minor NPE bug in delete-topic-manager. 5. Rolling bounce test case. Diffs ----- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java bedd2a989a62b1ed53f006e7e2f8bd1bdc5dfa5b clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java d8e35e7d0e4cd27aad9a8d4bf14bc97458da9417 clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java 699027447145837495fb56b41ad9ee5e9cb60240 clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java c7fbf3c06858a6016878667b68ee29b22b604f7d clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 794262394133d8e10e52971dccc0082d3aa75047 clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java 21a2592ea7c7f5d4831669196cf4e2d2b4e9bcf5 clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java 91b9d64aca2255ed3ae1283b2703c7a0f8757a55 clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java 73b700602006b881e4be75bb4b6d541e64f291e5 clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java PRE-CREATION core/src/main/scala/kafka/controller/KafkaController.scala b58cdcd16ffb62ba5329b8b2776f2bd18440b3a0 core/src/main/scala/kafka/log/LogManager.scala 10062af1e02af5e4238f408ba5b9f98cc226244f core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 4b7c544594dba734c8875fce2a289f81d67ba291 Diff: https://reviews.apache.org/r/18740/diff/ Testing ------- integration tests Thanks, Guozhang Wang --===============5150425235684109181==--