Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 68E8E107E7 for ; Mon, 3 Mar 2014 17:26:13 +0000 (UTC) Received: (qmail 33332 invoked by uid 500); 3 Mar 2014 17:26:12 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 33298 invoked by uid 500); 3 Mar 2014 17:26:12 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 33288 invoked by uid 99); 3 Mar 2014 17:26:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Mar 2014 17:26:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CC3DC1D4B33; Mon, 3 Mar 2014 17:26:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8502972599652251930==" MIME-Version: 1.0 Subject: Re: Review Request 18690: Patch for KAFKA-1287 From: "Neha Narkhede" To: "kafka" , "Jun Rao" , "Neha Narkhede" Date: Mon, 03 Mar 2014 17:26:10 -0000 Message-ID: <20140303172610.10089.96026@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Neha Narkhede" X-ReviewGroup: kafka X-ReviewRequest-URL: https://reviews.apache.org/r/18690/ X-Sender: "Neha Narkhede" References: <20140303161604.10116.23604@reviews.apache.org> In-Reply-To: <20140303161604.10116.23604@reviews.apache.org> Reply-To: "Neha Narkhede" X-ReviewRequest-Repository: kafka --===============8502972599652251930== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18690/#review35978 ----------------------------------------------------------- Ship it! Ship It! - Neha Narkhede On March 3, 2014, 4:16 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18690/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 4:16 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1287 > https://issues.apache.org/jira/browse/KAFKA-1287 > > > Repository: kafka > > > Description > ------- > > copy slf4jlog4j jar to dependant libs. Also remove the gradle warning on slf4jlog4j variable. > > > Diffs > ----- > > build.gradle 36ea2b79e8f2646fa2d7340b7f13940c812638a9 > > Diff: https://reviews.apache.org/r/18690/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > > --===============8502972599652251930==--