kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-1307) potential socket leak in new producer and clean up
Date Mon, 17 Mar 2014 20:06:42 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938304#comment-13938304
] 

Jun Rao commented on KAFKA-1307:
--------------------------------

The logging improvement is already committed in KAFKA-1302.

> potential socket leak in new producer and clean up
> --------------------------------------------------
>
>                 Key: KAFKA-1307
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1307
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.2
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: KAFKA-1307.patch
>
>
> Address the delta review comments from kafka-1227.
> 20. Selector and Sender: need to close socket channel on IOException in addition to UnresolvedHostnameException.
> 21. AbstractConfig:
> 21.1 To be consistent, we probably should change the return value of the following api
from Long to long.
> public Long getLong(String key)
> 21.1 Could we also add getDouble(String key)?
> 22. Metadata.fetch(): The wait time is incorrect when there is an InterruptedException.
> 23. Add comments on BufferPool.allocate() and Struct.instanceOf() for clarification.
> 24. Various other minor fixes for mis-spelling.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message