kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@gmail.com>
Subject Re: Review Request 19388: KAFKA-1251: Add metrics to the producer.
Date Wed, 19 Mar 2014 06:49:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19388/#review37692
-----------------------------------------------------------



clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java
<https://reviews.apache.org/r/19388/#comment69332>

    Not sure if this is intentional.



clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java
<https://reviews.apache.org/r/19388/#comment69333>

    Should all the callers also check null now?


- Timothy Chen


On March 19, 2014, 4:07 a.m., Jay Kreps wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19388/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 4:07 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1251
>     https://issues.apache.org/jira/browse/KAFKA-1251
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> This is a draft patch so we can discuss what to instrument.
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 1ac69436f117800815b8d50f042e9e2a29364b43

>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java 33d62a4b83fbab5b22b91b22f6b744af1c98d262

>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
673b2962771c28ceb3c7a6c0fd6f69521bd7ed16 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java
038a05a94b795ec0a95b2d40a89222394b5a74c4 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 565331dfb9cd1d65be37ed97830aa42e44d2e127

>   clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java 3ebbb804242be6a001b3bae6524afccc85a87602

>   clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java 7e4849b7a148009c8a878349d7f0239108ccad8c

>   clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java 3b0454f26490d1f4a2a80efb00165fc72587fbf8

>   clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java f8b413a8c273cdad56177fbc6971fece4feb86b3

>   clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java 9305b61ddeaa2bb400cbbb6d3c99c8ecaade6b8f

>   clients/src/main/java/org/apache/kafka/common/network/NetworkReceive.java 51d4892dfc18580e5e213d386c5de387a47d3c6b

>   clients/src/main/java/org/apache/kafka/common/network/Selector.java 983963200ce81614577cd6182a5d2f10c22b95d4

>   clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java 09a5355d25a3b94c8e23caa2adc77cb1c59368b9

>   clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java
ed5690641a22fbe4bd91b0c6055d465944b08c06 
>   clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java 12c9500ce4387306ab5aa7a5781b4aca52b86604

>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 90e2dcf5434db546387302fb0219edfdb363592e

>   clients/src/test/java/org/apache/kafka/test/MetricsBench.java 7239b4a56e93f019e66aa2cf2aa9b04c26908bfd

> 
> Diff: https://reviews.apache.org/r/19388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Kreps
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message