kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@gmail.com>
Subject Re: Review Request 19379: Patch for KAFKA-1311
Date Wed, 19 Mar 2014 00:18:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19379/#review37668
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On March 19, 2014, 12:14 a.m., Neha Narkhede wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19379/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 12:14 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1311
>     https://issues.apache.org/jira/browse/KAFKA-1311
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Joel's review comments
> 
> 
> 1. Removed --delete from topic command 2. Added config to turn off delete topic (delete.topic.enable)
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/TopicCommand.scala 6fef9df19fbc7caf90d0409bffd36fea1f4c4da5

>   core/src/main/scala/kafka/controller/PartitionStateMachine.scala c69077e6f4dc04232f63d748aa4e49d33d0cebc4

>   core/src/main/scala/kafka/controller/TopicDeletionManager.scala 58f1c4274e9f8ec3f4711974eae0588020c5c169

>   core/src/main/scala/kafka/server/KafkaConfig.scala 08de0eff67311e25d56d4133882faea6758c977c

>   core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 6db76a53173aab06b84203712c98313ce1e8b12e

> 
> Diff: https://reviews.apache.org/r/19379/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neha Narkhede
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message