kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 19379: Patch for KAFKA-1311
Date Tue, 18 Mar 2014 22:32:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19379/
-----------------------------------------------------------

(Updated March 18, 2014, 10:32 p.m.)


Review request for kafka.


Bugs: KAFKA-1311
    https://issues.apache.org/jira/browse/KAFKA-1311


Repository: kafka


Description (updated)
-------

1. Removed --delete from topic command 2. Added config to turn off delete topic (delete.topic.enable)

The reason I chose protecting all public APIs of TopicDeletionManager instead of protecting
everything that calls those APIs is only to contain the change. It will be a more widespread
and hence risky change to do the latter. Let me know if people think otherwise.


Diffs
-----

  core/src/main/scala/kafka/admin/TopicCommand.scala 6fef9df19fbc7caf90d0409bffd36fea1f4c4da5

  core/src/main/scala/kafka/controller/PartitionStateMachine.scala c69077e6f4dc04232f63d748aa4e49d33d0cebc4

  core/src/main/scala/kafka/controller/TopicDeletionManager.scala 58f1c4274e9f8ec3f4711974eae0588020c5c169

  core/src/main/scala/kafka/server/KafkaConfig.scala 08de0eff67311e25d56d4133882faea6758c977c

  core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 6db76a53173aab06b84203712c98313ce1e8b12e


Diff: https://reviews.apache.org/r/19379/diff/


Testing
-------


Thanks,

Neha Narkhede


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message