kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Kreps" <boredandr...@gmail.com>
Subject Re: Review Request 19311: Patch for KAFKA-1307
Date Tue, 18 Mar 2014 17:27:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19311/#review37567
-----------------------------------------------------------

Ship it!


Ship It!

- Jay Kreps


On March 18, 2014, 5:03 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19311/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 5:03 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1307
>     https://issues.apache.org/jira/browse/KAFKA-1307
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> switch back to IOException in SelectorTest.blockingConnect()
> 
> 
> convert UnresolvedAddressException to IOException in Selector
> 
> 
> Fixed the issues listed in the jira.
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java 5bed60730ea108684bea2440af5a008feb0ada61

>   clients/src/main/java/org/apache/kafka/clients/producer/internals/ErrorLoggingCallback.java
368e8f3b249e3d640240c73cd5ab1ad047b60aa7 
>   clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java db6e3a1842bfd034d55311f875afe7d7a97dfec5

>   clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
7a03f389cc6a4d56152b882555d7498af9a04d20 
>   clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java c989e251f6ecbe01a1daaf84dbe7147ec686afa1

>   clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java 61257d1ac6ee3db8f6824617d6e35e8527f1b62a

>   clients/src/main/java/org/apache/kafka/common/network/Selector.java f83189d3ce4169523e40a5631435fcf59777d7fb

>   clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java dc03fd04c981dfac7f16f61c9cbfa7f1f4c324c8

>   clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java 865996c1fb5d8852db26c8618203a1d6429625d2

>   core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala 6f9054953392807a901301d72ee7ab107a09ad84

>   perf/src/main/scala/kafka/perf/ProducerPerformance.scala f12a45becb11a8bed586024866235b268630fec6

> 
> Diff: https://reviews.apache.org/r/19311/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message