kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 19338: Patch for KAFKA-1309
Date Tue, 18 Mar 2014 15:03:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19338/#review37555
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On March 18, 2014, 7:53 a.m., joel koshy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19338/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 7:53 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1309
>     https://issues.apache.org/jira/browse/KAFKA-1309
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> fix
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/api/OffsetCommitRequest.scala 9f6956e97b5e53fe91a323f1ee49ea95b8476348

>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 9a3db904915f2874b1ba223d7ed01d497421a846

>   core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 6de320dcc0d9373dd046bda0ea68a9c9f8931630

>   core/src/test/scala/other/kafka/TestOffsetManager.scala 83317f07611b6877bbeb62a5ef34f8d31bf978d7

>   core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 53784466149569a4d4dc039e079c4e92c80ff0d1

>   core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala e63299762dcfec47c2957dd46a833c430fee591a

> 
> Diff: https://reviews.apache.org/r/19338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> joel koshy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message