kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neha Narkhede" <neha.narkh...@gmail.com>
Subject Re: Review Request 17537: Patch for KAFKA-1028
Date Mon, 17 Mar 2014 18:16:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17537/#review37419
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On March 17, 2014, 2:39 p.m., Andrew Olson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17537/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 2:39 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1028
>     https://issues.apache.org/jira/browse/KAFKA-1028
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1028: per topic configuration of preference for consistency over availability
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/common/NoReplicaOnlineException.scala a1e12794978adf79020936c71259bbdabca8ee68

>   core/src/main/scala/kafka/controller/KafkaController.scala 5db24a73a62c725a76c79936abb15b1fda3b770b

>   core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala fa29bbe82db35551f43ac487912fba7bae1b2599

>   core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b

>   core/src/main/scala/kafka/server/KafkaConfig.scala d07796ec87fa9bf0d13e1690240b85979aba3224

>   core/src/main/scala/kafka/server/ReplicaFetcherThread.scala 73e605eb31bc71642d48b0bb8bd1632fd70b9dca

>   core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala b585f0ec0b1c402d95a3b34934dab7545dcfcb1f

>   core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala PRE-CREATION

>   core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala 89c207a3f56c7a7711f8cee6fb277626329882a6

>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 772d2140ed926a2f9f0c99aea60daf1a9b987073

> 
> Diff: https://reviews.apache.org/r/17537/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Olson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message