kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Olson" <aols...@cerner.com>
Subject Re: Review Request 17537: Patch for KAFKA-1028
Date Tue, 04 Mar 2014 00:50:40 GMT


> On Feb. 4, 2014, 11:21 p.m., Neha Narkhede wrote:
> > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala, line 86
> > <https://reviews.apache.org/r/17537/diff/3/?file=456708#file456708line86>
> >
> >     Reading from zookeeper is unnecessary here, since the broker has a mechanism
to load per topic configs on the fly. Just accessing it through the config object should suffice
> 
> Neha Narkhede wrote:
>     Here you could just do 
>     
>     if(brokerConfig.uncleanLeaderElectionEnable) instead of if (!AdminUtils.canElectUncleanLeaderForTopic(replicaMgr.zkClient,
topicAndPartition.topic, brokerConfig.uncleanLeaderElectionEnable))
>     
>     To understand how the broker dynamically loads per topic configs, you can look at
TopicConfigManager. It registers a zookeeper listener on the topic config change path and
atomically switches the log config object to reflect the new per topic config overrides.

See justification in PartitionLeaderSelector comment thread above.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17537/#review33658
-----------------------------------------------------------


On March 4, 2014, 12:48 a.m., Andrew Olson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17537/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 12:48 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1028
>     https://issues.apache.org/jira/browse/KAFKA-1028
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1028: per topic configuration of preference for consistency over availability
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala 36ddeb44490e8343a4e8056c45726ac660e4b2f9

>   core/src/main/scala/kafka/common/NoReplicaOnlineException.scala a1e12794978adf79020936c71259bbdabca8ee68

>   core/src/main/scala/kafka/controller/KafkaController.scala b58cdcd16ffb62ba5329b8b2776f2bd18440b3a0

>   core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala fa29bbe82db35551f43ac487912fba7bae1b2599

>   core/src/main/scala/kafka/log/LogConfig.scala 0b32aeeffcd9d4755ac90573448d197d3f729749

>   core/src/main/scala/kafka/server/KafkaConfig.scala 04a5d39be3c41f5cb3589d95d0bd0f4fb4d7030d

>   core/src/main/scala/kafka/server/ReplicaFetcherThread.scala 73e605eb31bc71642d48b0bb8bd1632fd70b9dca

>   core/src/test/scala/unit/kafka/admin/AdminTest.scala d5644ea40ec7678b975c4775546b79fcfa9f64b7

>   core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala b585f0ec0b1c402d95a3b34934dab7545dcfcb1f

>   core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala PRE-CREATION

>   core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala 89c207a3f56c7a7711f8cee6fb277626329882a6

>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 772d2140ed926a2f9f0c99aea60daf1a9b987073

> 
> Diff: https://reviews.apache.org/r/17537/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Olson
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message