Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E43499150 for ; Tue, 5 Mar 2013 00:09:12 +0000 (UTC) Received: (qmail 55541 invoked by uid 500); 5 Mar 2013 00:09:12 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 55510 invoked by uid 500); 5 Mar 2013 00:09:12 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 55500 invoked by uid 99); 5 Mar 2013 00:09:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2013 00:09:12 +0000 Date: Tue, 5 Mar 2013 00:09:12 +0000 (UTC) From: "Sriram Subramanian (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-785: ------------------------------------- Attachment: KAFKA-785.patch 1. Made partition input file optional for PreferredReplicaLeaderElectionCommand 2. Removed shutdown hook from PreferredReplicaLeaderElectionCommand and ReassignPartitionsCommand as it was causing NPE and it was not useful since the operations on the controller are asynchronous. > Resolve bugs in PreferredReplicaLeaderElection admin tool > --------------------------------------------------------- > > Key: KAFKA-785 > URL: https://issues.apache.org/jira/browse/KAFKA-785 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Swapnil Ghike > Assignee: Sriram Subramanian > Priority: Blocker > Labels: kafka-0.8, p2 > Fix For: 0.8 > > Attachments: KAFKA-785.patch > > > 1. Since we run the preferred replica election on all partitions if the jsonFile is empty, the jsonFileOpt should not be checked in the code as a required option. > 2. We should not pass "" to Utils.readFileAsString > 3. KAFKA-780 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira