Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D1B09912E for ; Tue, 5 Mar 2013 00:03:12 +0000 (UTC) Received: (qmail 37742 invoked by uid 500); 5 Mar 2013 00:03:12 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 37711 invoked by uid 500); 5 Mar 2013 00:03:12 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 37698 invoked by uid 99); 5 Mar 2013 00:03:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2013 00:03:12 +0000 Date: Tue, 5 Mar 2013 00:03:12 +0000 (UTC) From: "Swapnil Ghike (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-785: -------------------------------- Description: 1. Since we run the preferred replica election on all partitions if the jsonFile is empty, the jsonFileOpt should not be checked in the code as a required option. 2. We should not pass "" to Utils.readFileAsString 3. KAFKA-780 was:Since we run the preferred replica election on all partitions if the jsonFile is empty, the jsonFileOpt should be optional. > Resolve bugs in PreferredReplicaLeaderElection admin tool > --------------------------------------------------------- > > Key: KAFKA-785 > URL: https://issues.apache.org/jira/browse/KAFKA-785 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Swapnil Ghike > Assignee: Swapnil Ghike > Priority: Blocker > Labels: kafka-0.8, p2 > Fix For: 0.8 > > > 1. Since we run the preferred replica election on all partitions if the jsonFile is empty, the jsonFileOpt should not be checked in the code as a required option. > 2. We should not pass "" to Utils.readFileAsString > 3. KAFKA-780 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira