kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Arthur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-771) NPE in handleOffsetCommitRequest
Date Sat, 23 Feb 2013 03:56:12 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584996#comment-13584996
] 

David Arthur commented on KAFKA-771:
------------------------------------

Isn't there a more "Scala-y" way to do this sort of thing? Perhaps if ApiUtils#readShortString
returned Option(String) instead of just String? OffsetMetadataAndError would need to do the
same thing. This would be a large refactoring due to the ubiquity of readShortString
                
> NPE in handleOffsetCommitRequest
> --------------------------------
>
>                 Key: KAFKA-771
>                 URL: https://issues.apache.org/jira/browse/KAFKA-771
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: David Arthur
>            Assignee: David Arthur
>             Fix For: 0.8
>
>         Attachments: 0001-KAFKA-771-Add-null-check-to-offset-metadata.patch
>
>
> If the metadata string is null, we get an NPE on the length check

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message