Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 399A1EFAF for ; Fri, 11 Jan 2013 22:00:13 +0000 (UTC) Received: (qmail 87858 invoked by uid 500); 11 Jan 2013 22:00:13 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 87825 invoked by uid 500); 11 Jan 2013 22:00:13 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 87813 invoked by uid 99); 11 Jan 2013 22:00:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2013 22:00:13 +0000 Date: Fri, 11 Jan 2013 22:00:12 +0000 (UTC) From: "Jun Rao (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551550#comment-13551550 ] Jun Rao commented on KAFKA-683: ------------------------------- The changes in core/src/test/resources/log4j.properties are not intended, right? Other than that, +1 on the latest patch. We can have another jira to clean up the request string format. > Fix correlation ids in all requests sent to kafka > ------------------------------------------------- > > Key: KAFKA-683 > URL: https://issues.apache.org/jira/browse/KAFKA-683 > Project: Kafka > Issue Type: Improvement > Affects Versions: 0.8 > Reporter: Neha Narkhede > Assignee: Neha Narkhede > Priority: Critical > Labels: improvement, replication > Attachments: kafka-683-v1.patch, kafka-683-v2.patch, kafka-683-v2-rebased.patch, kafka-683-v2-rebased-twice.patch, kafka-683-v3.patch, kafka-683-v3-unit-test.patch > > > We should fix the correlation ids in every request sent to Kafka and fix the request log on the broker to specify not only the type of request and who sent it, but also the correlation id. This will be very helpful while troubleshooting problems in production. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira