Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Thu, 10 Jan 2013 18:56:16 +0000 (UTC)
From: "Neha Narkhede (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12626087.1357327194128.114800.1357844176242@arcas>
In-Reply-To: <JIRA.12626087.1357327194128@arcas>
References: <JIRA.12626087.1357327194128@arcas>
Subject: [jira] [Updated] (KAFKA-683) Fix correlation ids in all requests
 sent to kafka
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede updated KAFKA-683:
--------------------------------

    Attachment: kafka-683-v2-rebased.patch

I see, I misunderstood your suggestion then. The reason I added the version, correlation id information explicitly is to make it easier to trace requests through the socket server to the request handler. In fact, I think logging the entire request might not be very useful if we do a good job of logging the correlation id and request type properly throughout our codebase. My plan was to remove it after we are sufficiently satisfied with troubleshooting problems just based on the correlation id wiring that we have currently. I will do a follow up to remove the logging of the request after that. Does that work for you ?
                
> Fix correlation ids in all requests sent to kafka
> -------------------------------------------------
>
>                 Key: KAFKA-683
>                 URL: https://issues.apache.org/jira/browse/KAFKA-683
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Critical
>              Labels: improvement, replication
>         Attachments: kafka-683-v1.patch, kafka-683-v2.patch, kafka-683-v2-rebased.patch
>
>
> We should fix the correlation ids in every request sent to Kafka and fix the request log on the broker to specify not only the type of request and who sent it, but also the correlation id. This will be very helpful while troubleshooting problems in production.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira