Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Wed, 2 Jan 2013 20:44:12 +0000 (UTC)
From: "Joel Koshy (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.12619154.1354812529928.70836.1357159452372@arcas>
In-Reply-To: <JIRA.12619154.1354812529928@arcas>
References: <JIRA.12619154.1354812529928@arcas>
Subject: [jira] [Commented] (KAFKA-657) Add an API to commit offsets
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542390#comment-13542390 ] 

Joel Koshy commented on KAFKA-657:
----------------------------------

Hey David, the patch (and the wiki) looks great.

- For error handling. I think what Jun was referring to is the giant catch clause in handle - i.e., the new keys
  should be added as a case. That junk block of code really needs to be cleaned up :)
- KafkaApis: if(offsetStr == null) : I don't think this can happen.
- Default client id should probably be "" in all the request/responses i.e., to follow convention.
- It would be better to use 1.toShort or val CurrentVersion: Short = 1 (instead of 1.shortValue); although it's more
  or less a non-issue as it's in the object.

                
> Add an API to commit offsets
> ----------------------------
>
>                 Key: KAFKA-657
>                 URL: https://issues.apache.org/jira/browse/KAFKA-657
>             Project: Kafka
>          Issue Type: New Feature
>            Reporter: Jay Kreps
>              Labels: project
>         Attachments: KAFKA-657v1.patch, KAFKA-657v2.patch, KAFKA-657v3.patch, KAFKA-657v4.patch, KAFKA-657v5.patch, KAFKA-657v6.patch
>
>
> Currently the consumer directly writes their offsets to zookeeper. Two problems with this: (1) This is a poor use of zookeeper, and we need to replace it with a more scalable offset store, and (2) it makes it hard to carry over to clients in other languages. A first step towards accomplishing that is to add a proper Kafka API for committing offsets. The initial version of this would just write to zookeeper as we do today, but in the future we would then have the option of changing this.
> This api likely needs to take a sequence of consumer-group/topic/partition/offset entries and commit them all.
> It would be good to do a wiki design on how this would work and consensus on that first.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira