Return-Path: X-Original-To: apmail-kafka-dev-archive@www.apache.org Delivered-To: apmail-kafka-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8242AD539 for ; Fri, 11 Jan 2013 00:06:13 +0000 (UTC) Received: (qmail 21266 invoked by uid 500); 11 Jan 2013 00:06:13 -0000 Delivered-To: apmail-kafka-dev-archive@kafka.apache.org Received: (qmail 21235 invoked by uid 500); 11 Jan 2013 00:06:13 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 21226 invoked by uid 99); 11 Jan 2013 00:06:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2013 00:06:13 +0000 Date: Fri, 11 Jan 2013 00:06:13 +0000 (UTC) From: "Sriram Subramanian (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-648) Use uniform convention for naming properties keys MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-648: ------------------------------------- Attachment: configchanges-v5.patch 40 / 42/ 43 Accepted the suggestions but handled them differently. Specifying max and min at the beginning will cause configs related to the same feature to not look similar. For Example, max.log.Index.size and log.roll.hours are both configs related to logs but end up looking different. Instead, the configs use the following format - ConfigName => ComponentName AnyString [Max/Min] [Unit] FeatureName => Name of the component/feature this config is used for. Example - log, replica, etc. AnyString => A string that represents what this config is used for Max/Min => Optional. Used if the config represents a max or min value. For example, replicaLagTimeMaxMs Unit => Optional. The unit of the value the config represents. For example, replicaLagMaxBytes for value specified in bytes. 41 Removed the producer prefix in producer configs. John you may have to fix the json files once more to work with the new changes. > Use uniform convention for naming properties keys > -------------------------------------------------- > > Key: KAFKA-648 > URL: https://issues.apache.org/jira/browse/KAFKA-648 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Swapnil Ghike > Assignee: Sriram Subramanian > Priority: Blocker > Fix For: 0.8, 0.8.1 > > Attachments: configchanges-1.patch, configchanges-v2.patch, configchanges-v3.patch, configchanges-v4.patch, configchanges-v5.patch > > > Currently, the convention that we seem to use to get a property value in *Config is as follows: > val configVal = property.getType("config.val", ...) // dot is used to separate two words in the key and the first letter of second word is capitalized in configVal. > We should use similar convention for groupId, consumerId, clientId, correlationId. > This change will probably be backward non-compatible. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira